fix: crash on delete DataSet #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1531 +/- ##
==========================================
- Coverage 85.17% 85.09% -0.08%
==========================================
Files 562 563 +1
Lines 28074 28157 +83
Branches 7722 7240 -482
==========================================
+ Hits 23911 23961 +50
- Misses 3860 4040 +180
+ Partials 303 156 -147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 09m 40s |
| Commit |
|
| Committer | Kirk Swenson |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
30
|
Skipped
|
0
|
Passing
|
227
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several things going on here:
GraphDataConfigurationModel's attempt to synchronize itsfilteredCasesarray after itsDataSetwas destroyed.Once that was fixed, there were still several clients that were attempting to access the defunct
DataSettriggering warnings. These have also been fixed:FilteredCasesclass now responds to disposal of itsDataSet, thus preventing further access.CaseTile'sHideShowMenuListchecks whether itsDataSetis alive before accessing it. (We conventionally avoidisAlivein models, but in components there often isn't a better way.)CountAdornmentComponentwas properly usingmstAutorun, but the model it was attached to was theCountAdornmentModel, not the axis models that were also accessed within theautorun.mstAutorunandmstReactionhave been extended to support an array of model dependencies or a single model and so now theCountAdornmentComponentcan specify all of its model dependencies. (I have wondered for some time whether we would ever encounter a situation in which a single model dependency was insufficient for these utilities and now we have.)